diff --git a/arch/mips/include/asm/sn/hub.h b/arch/mips/include/asm/sn/hub.h index 338f7eed74f1..9e6d76f8d12a 100644 --- a/arch/mips/include/asm/sn/hub.h +++ b/arch/mips/include/asm/sn/hub.h @@ -10,8 +10,8 @@ #include /* ip27-hubio.c */ -extern unsigned long hub_pio_map(cnodeid_t cnode, xwidgetnum_t widget, - unsigned long xtalk_addr, size_t size); +extern unsigned long hub_pio_map(cnodeid_t cnode, s8 widget, + unsigned long xtalk_addr, size_t size); extern void hub_pio_init(cnodeid_t cnode); #endif /* __ASM_SN_HUB_H */ diff --git a/arch/mips/include/asm/xtalk/xtalk.h b/arch/mips/include/asm/xtalk/xtalk.h index 26d2ed1fa917..9125bd85514d 100644 --- a/arch/mips/include/asm/xtalk/xtalk.h +++ b/arch/mips/include/asm/xtalk/xtalk.h @@ -13,30 +13,14 @@ #define _ASM_XTALK_XTALK_H #ifndef __ASSEMBLY__ -/* - * User-level device driver visible types - */ -typedef char xwidgetnum_t; /* xtalk widget number (0..15) */ +/* Xtalk "none" values. */ #define XWIDGET_NONE -1 - -typedef int xwidget_part_num_t; /* xtalk widget part number */ - #define XWIDGET_PART_NUM_NONE -1 - -typedef int xwidget_rev_num_t; /* xtalk widget revision number */ - #define XWIDGET_REV_NUM_NONE -1 - -typedef int xwidget_mfg_num_t; /* xtalk widget manufacturing ID */ - #define XWIDGET_MFG_NUM_NONE -1 -typedef struct xtalk_piomap_s *xtalk_piomap_t; - -/* It is often convenient to fold the XIO target port - * number into the XIO address. - */ +/* It is often convenient to fold the XIO target port */ #define XIO_NOWHERE (0xFFFFFFFFFFFFFFFFull) #define XIO_ADDR_BITS (0x0000FFFFFFFFFFFFull) #define XIO_PORT_BITS (0xF000000000000000ull) @@ -44,7 +28,7 @@ typedef struct xtalk_piomap_s *xtalk_piomap_t; #define XIO_PACKED(x) (((x)&XIO_PORT_BITS) != 0) #define XIO_ADDR(x) ((x)&XIO_ADDR_BITS) -#define XIO_PORT(x) ((xwidgetnum_t)(((x)&XIO_PORT_BITS) >> XIO_PORT_SHIFT)) +#define XIO_PORT(x) ((s8)(((x)&XIO_PORT_BITS) >> XIO_PORT_SHIFT)) #define XIO_PACK(p, o) ((((uint64_t)(p))<